From 57038dc5f041c62a910a2292d7489958c9e02ca3 Mon Sep 17 00:00:00 2001
From: AhnafAhamed <ahnafahamed4@gmail.com>
Date: Wed, 21 Sep 2022 23:12:07 +0530
Subject: [PATCH] review 2 fixes

---
 docs/components/card/card.md                   | 18 +++++++++---------
 .../card/examples/CardDefaultExample.vue       |  2 +-
 .../card/examples/CardHorizontalExample.vue    |  2 +-
 .../card/examples/CardImageExample.vue         |  2 +-
 src/components/Card/TheCard.vue                |  8 ++++----
 .../Card/composables/useCardClasses.ts         | 12 ++++++------
 src/index.ts                                   |  2 --
 7 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/docs/components/card/card.md b/docs/components/card/card.md
index 45b17e4..fa37f6e 100644
--- a/docs/components/card/card.md
+++ b/docs/components/card/card.md
@@ -24,7 +24,7 @@ Use these responsive card components to show data entries and information to you
 import { TheCard } from 'flowbite-vue'
 </script>
 <template>
-  <the-card :href="'#'"/>
+  <the-card href="#"/>
 </template>
 ```
 
@@ -38,10 +38,10 @@ import { TheCard } from 'flowbite-vue'
 </script>
 <template>
   <the-card 
-    :variant="'image'" 
-    :href="'#'" 
-    :img-src="'./images/blog/image-1.jpg'" 
-    :img-alt="'Image'"
+    variant="image" 
+    href="#" 
+    img-src="./images/blog/image-1.jpg" 
+    img-alt="Image"
   />
 </template>
 ```
@@ -56,10 +56,10 @@ import { TheCard } from 'flowbite-vue'
 </script>
 <template>
   <the-card 
-    :variant="'horizontal'" 
-    :href="'#'" 
-    :img-src="'./images/blog/image-4.jpg'" 
-    :img-alt="'Image'"
+    variant="horizontal" 
+    href="#" 
+    img-src="./images/blog/image-4.jpg" 
+    img-alt="Image"
   />
 </template>
 ```
diff --git a/docs/components/card/examples/CardDefaultExample.vue b/docs/components/card/examples/CardDefaultExample.vue
index adbda76..e28806c 100644
--- a/docs/components/card/examples/CardDefaultExample.vue
+++ b/docs/components/card/examples/CardDefaultExample.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="vp-raw inline-flex align-center gap-2 flex-wrap">
-    <the-card :href="'#'">
+    <the-card href="#">
       <h5 class="mb-2 text-2xl font-bold tracking-tight text-gray-900 dark:text-white">Noteworthy technology acquisitions 2021</h5>
       <p class="font-normal text-gray-700 dark:text-gray-400">Here are the biggest enterprise technology acquisitions of 2021 so far, in reverse chronological order.</p>
     </the-card>
diff --git a/docs/components/card/examples/CardHorizontalExample.vue b/docs/components/card/examples/CardHorizontalExample.vue
index 7defb5d..7c8258a 100644
--- a/docs/components/card/examples/CardHorizontalExample.vue
+++ b/docs/components/card/examples/CardHorizontalExample.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="vp-raw inline-flex align-center gap-2 flex-wrap">
-    <the-card :href="'#'" :variant="'horizontal'" :img-src="'https://flowbite.com/docs/images/blog/image-4.jpg'" :imgAlt="'Desk'">
+    <the-card href="#" variant="horizontal" img-src="https://flowbite.com/docs/images/blog/image-4.jpg" img-alt="Desk">
       <h5 class="mb-2 text-2xl font-bold tracking-tight text-gray-900 dark:text-white">Noteworthy technology acquisitions 2021</h5>
       <p class="font-normal text-gray-700 dark:text-gray-400">Here are the biggest enterprise technology acquisitions of 2021 so far, in reverse chronological order.</p>
     </the-card>
diff --git a/docs/components/card/examples/CardImageExample.vue b/docs/components/card/examples/CardImageExample.vue
index 08a4616..6179d4a 100644
--- a/docs/components/card/examples/CardImageExample.vue
+++ b/docs/components/card/examples/CardImageExample.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="vp-raw inline-flex align-center gap-2 flex-wrap">
-    <the-card :href="'#'" :variant="'image'" :img-src="'https://flowbite.com/docs/images/blog/image-1.jpg'" :imgAlt="'Desk'">
+    <the-card href="#" variant="image" img-src="https://flowbite.com/docs/images/blog/image-1.jpg" img-alt="Desk">
       <h5 class="mb-2 text-2xl font-bold tracking-tight text-gray-900 dark:text-white">Noteworthy technology acquisitions 2021</h5>
       <p class="font-normal text-gray-700 dark:text-gray-400">Here are the biggest enterprise technology acquisitions of 2021 so far, in reverse chronological order.</p>
     </the-card>
diff --git a/src/components/Card/TheCard.vue b/src/components/Card/TheCard.vue
index 7a0364f..1270084 100644
--- a/src/components/Card/TheCard.vue
+++ b/src/components/Card/TheCard.vue
@@ -1,11 +1,10 @@
 <template>
-  <a :href="href" :class="cardClasses">
+  <component :is="wrapperType" :href="href" :class="cardClasses">
     <img v-if="imgSrc" class="rounded-t-lg" :class="horizontalImageClasses" :src="imgSrc" :alt="imgAlt"/>
     <div class="p-6">
       <slot />
     </div>
-    
-  </a>
+  </component>
 </template>
 <script lang="ts" setup>
 import { computed, toRefs } from 'vue'
@@ -32,6 +31,7 @@ const props = defineProps({
   },
 })
 
-const { cardClasses, horizontalImageClasses } = useCardsClasses(props)
+const { cardClasses, horizontalImageClasses } = useCardsClasses(toRefs(props))
+const wrapperType = computed(() => props.href ? 'a' : 'div')
 
 </script>
diff --git a/src/components/Card/composables/useCardClasses.ts b/src/components/Card/composables/useCardClasses.ts
index aaa4565..ff1a4a4 100644
--- a/src/components/Card/composables/useCardClasses.ts
+++ b/src/components/Card/composables/useCardClasses.ts
@@ -1,9 +1,9 @@
 import type { Ref } from 'vue'
-import { computed, useSlots } from 'vue'
+import { computed } from 'vue'
 import type { CardsVariant } from '../types'
 
 export type UseCardsClassesProps = {
-    variant: CardsVariant
+    variant: Ref<CardsVariant>
 }
 
 export function useCardsClasses(props: UseCardsClassesProps): {
@@ -11,17 +11,17 @@ export function useCardsClasses(props: UseCardsClassesProps): {
     horizontalImageClasses: Ref<string>
 } {
     const cardClasses = computed(() => {
-        if(props.variant === 'default') 
+        if(props.variant.value === 'default') 
             return 'block max-w-sm bg-white rounded-lg border border-gray-200 shadow-md hover:bg-gray-100 dark:bg-gray-800 dark:border-gray-700 dark:hover:bg-gray-700'
-        else if(props.variant === 'image')
+        else if(props.variant.value === 'image')
             return 'max-w-sm bg-white rounded-lg border border-gray-200 shadow-md dark:bg-gray-800 dark:border-gray-700'
-        else if(props.variant === 'horizontal')
+        else if(props.variant.value === 'horizontal')
             return 'flex flex-col items-center bg-white rounded-lg border shadow-md md:flex-row md:max-w-xl hover:bg-gray-100 dark:border-gray-700 dark:bg-gray-800 dark:hover:bg-gray-700'
         return ''
     })
 
     const horizontalImageClasses = computed(() => {
-        if(props.variant === 'horizontal')
+        if(props.variant.value === 'horizontal')
             return 'object-cover w-full h-96 rounded-t-lg md:h-auto md:w-48 md:rounded-none md:rounded-l-lg'
         return ''
     })
diff --git a/src/index.ts b/src/index.ts
index 8991673..89206e9 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -13,9 +13,7 @@ export { default as Avatar } from './components/Avatar/Avatar.vue'
 export { default as StackedAvatars } from './components/Avatar/StackedAvatars.vue'
 export { default as StackedAvatarsCounter } from './components/Avatar/StackedAvatarsCounter.vue'
 export { default as Accordion } from './components/Accordion/Accordion.vue'
-
 export { default as Badge } from './components/Badge/Badge.vue'
-export { default as Breadcrumb } from './components/Breadcrumb/Breadcrumb.vue'
 export { default as TheCard } from './components/Card/TheCard.vue'
 export { default as Carousel } from './components/Carousel/Carousel.vue'
 export { default as Footer } from './components/Footer/Footer.vue'