Address PR comments

This commit is contained in:
Dmitri
2022-10-02 17:25:01 -07:00
parent 19542da005
commit 923645b4b3
4 changed files with 23 additions and 16 deletions

View File

@@ -39,8 +39,10 @@
</Modal>
</div>
</template>
<script setup>
import { Modal } from '../../../../src/index';
<script lang="ts" setup>
import { Modal } from '../../../../src/index'
import type { PropType } from 'vue'
import type { ModalSize, ModalPosition } from '../../../../src/components/Modal/types'
const props = defineProps({
children: {
type: Array,
@@ -53,7 +55,7 @@ const props = defineProps({
default: false,
},
position: {
type: String, // 'bottom-left' | 'bottom-right' | 'bottom-center' | 'top-left' | 'top-center' | 'top-right' | 'center-left' | 'center' | 'center-right'
type: String as PropType<ModalPosition>,
default: 'center',
},
show: {
@@ -61,7 +63,7 @@ const props = defineProps({
default: false,
},
size: {
type: String, // 'sm' | 'md' | 'lg' | 'xl' | '2xl' | '3xl' | '4xl' | '5xl' | '6xl' | '7xl'
type: String as PropType<ModalSize>,
default: '2xl',
},
triggerText: {

View File

@@ -1,16 +1,16 @@
<template>
<div class="vp-raw flex justify-between">
<span>
<ModalExample size="xs" trigger-text="XS Modal"/>
<ModalExample size="xs" trigger-text="XS Modal" />
</span>
<span>
<ModalExample size="md" trigger-text="MD Modal"/>
<ModalExample size="md" trigger-text="MD Modal" />
</span>
<span>
<ModalExample size="xl" trigger-text="XL Modal"/>
<ModalExample size="xl" trigger-text="XL Modal" />
</span>
<span>
<ModalExample size="5xl" trigger-text="5XL Modal"/>
<ModalExample size="5xl" trigger-text="5XL Modal" />
</span>
</div>
</template>