From c35161ab10168bf6113bf622d2af01893d0a80b5 Mon Sep 17 00:00:00 2001 From: Ilya Artamonov Date: Sun, 20 Nov 2022 21:07:51 +0300 Subject: [PATCH 1/3] chore: Eslint fixes --- .../composables/useProgressClasses.ts | 26 +++++-------------- 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/src/components/Progress/composables/useProgressClasses.ts b/src/components/Progress/composables/useProgressClasses.ts index f97f30b..d972378 100644 --- a/src/components/Progress/composables/useProgressClasses.ts +++ b/src/components/Progress/composables/useProgressClasses.ts @@ -39,40 +39,26 @@ export type UseProgressClassesProps = { } export function useProgressClasses(props: UseProgressClassesProps): { innerClasses: Ref, outerClasses: Ref, outsideLabelClasses: Ref} { - const bindClasses = computed(() => { - let colorClass = '' - colorClass = barColorClasses[props.color.value] - - let sizeClass = '' - sizeClass = progressSizeClasses[props.size.value] - return classNames( - colorClass, - sizeClass, + barColorClasses[props.color.value], + progressSizeClasses[props.size.value], ) }) - const outerClasses = computed(() => { - let outerSizeClass = '' - outerSizeClass = progressSizeClasses[props.size.value] return classNames( - outerSizeClass + progressSizeClasses[props.size.value], ) }) - const outsideLabelClasses = computed(() => { - let outsideLabelClass = '' - outsideLabelClass = outsideTextColorClasses[props.color.value] return classNames( - outsideLabelClass + outsideTextColorClasses[props.color.value], ) }) - return { innerClasses: bindClasses, outerClasses, - outsideLabelClasses + outsideLabelClasses, } -} \ No newline at end of file +} From 730393a66c7d041bd865b0f235daf0e5fffc4234 Mon Sep 17 00:00:00 2001 From: Ilya Artamonov Date: Sun, 20 Nov 2022 21:08:25 +0300 Subject: [PATCH 2/3] feat: Fixed import --- docs/components/progress/examples/ProgressColorExample.vue | 4 ++-- docs/components/progress/examples/ProgressExample.vue | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/components/progress/examples/ProgressColorExample.vue b/docs/components/progress/examples/ProgressColorExample.vue index 4015895..9f8879c 100644 --- a/docs/components/progress/examples/ProgressColorExample.vue +++ b/docs/components/progress/examples/ProgressColorExample.vue @@ -11,5 +11,5 @@ \ No newline at end of file +import { Progress } from 'flowbite-vue' + diff --git a/docs/components/progress/examples/ProgressExample.vue b/docs/components/progress/examples/ProgressExample.vue index bd62efb..ef6b943 100644 --- a/docs/components/progress/examples/ProgressExample.vue +++ b/docs/components/progress/examples/ProgressExample.vue @@ -4,5 +4,5 @@ From bbb3f1f90c6618cddf3afe1613e52859b5b63631 Mon Sep 17 00:00:00 2001 From: Ilya Artamonov Date: Sun, 20 Nov 2022 21:08:44 +0300 Subject: [PATCH 3/3] feat: Added type --- src/components/Progress/Progress.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Progress/Progress.vue b/src/components/Progress/Progress.vue index 2237753..61cbd5b 100644 --- a/src/components/Progress/Progress.vue +++ b/src/components/Progress/Progress.vue @@ -43,7 +43,7 @@ const props = defineProps({ default: 0, }, size: { - type: String, // 'sm' | 'md' | 'lg' | 'xl' + type: String as PropType, default: 'md', }, })